sgraenitz added inline comments.
================
Comment at: lldb/trunk/cmake/modules/LLDBStandalone.cmake:20
+ # We set LLVM_MAIN_INCLUDE_DIR so that it gets included in TableGen flags.
+ set(LLVM_MAIN_INCLUDE_DIR "${LLVM_BUILD_MAIN_INCLUDE_DIR}" CACHE PATH "Path
to LLVM's source include dir")
+ # We set LLVM_CMAKE_PATH so that GetSVN.cmake is found correctly when
building SVNVersion.inc
----------------
mgorny wrote:
> Apparently the idea of using `LLVM_BUILD_MAIN_INCLUDE_DIR` is plain wrong
> here. The old code used the equivalent of `LLVM_INCLUDE_DIR` (i.e. the
> include dir of *installed* LLVM) and I think the new code should use the
> same. Given how long the old code was there, I suppose there shouldn't be any
> use case broken by using that directory.
Please note that it works well when running against a LLVM/Clang build-tree,
which is a very common (but indeed not the only) use case this code should
support.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56531/new/
https://reviews.llvm.org/D56531
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
