aprantl created this revision. aprantl added a reviewer: clayborg. These conditions appear to always be true.
@clayborg do you remember the reason why these exist? https://reviews.llvm.org/D58838 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Target/ExecutionContext.cpp Index: lldb/source/Target/ExecutionContext.cpp =================================================================== --- lldb/source/Target/ExecutionContext.cpp +++ lldb/source/Target/ExecutionContext.cpp @@ -224,30 +224,22 @@ } Target &ExecutionContext::GetTargetRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_target_sp); -#endif return *m_target_sp; } Process &ExecutionContext::GetProcessRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_process_sp); -#endif return *m_process_sp; } Thread &ExecutionContext::GetThreadRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_thread_sp); -#endif return *m_thread_sp; } StackFrame &ExecutionContext::GetFrameRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_frame_sp); -#endif return *m_frame_sp; } Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp =================================================================== --- lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -2511,8 +2511,6 @@ return enumerators_added; } -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) - class DIEStack { public: void Push(const DWARFDIE &die) { m_dies.push_back(die); } @@ -2557,7 +2555,6 @@ typedef std::vector<DWARFDIE> Stack; Stack m_dies; }; -#endif Function *DWARFASTParserClang::ParseFunctionFromDWARF(CompileUnit &comp_unit, const DWARFDIE &die) {
Index: lldb/source/Target/ExecutionContext.cpp =================================================================== --- lldb/source/Target/ExecutionContext.cpp +++ lldb/source/Target/ExecutionContext.cpp @@ -224,30 +224,22 @@ } Target &ExecutionContext::GetTargetRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_target_sp); -#endif return *m_target_sp; } Process &ExecutionContext::GetProcessRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_process_sp); -#endif return *m_process_sp; } Thread &ExecutionContext::GetThreadRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_thread_sp); -#endif return *m_thread_sp; } StackFrame &ExecutionContext::GetFrameRef() const { -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) assert(m_frame_sp); -#endif return *m_frame_sp; } Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp =================================================================== --- lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -2511,8 +2511,6 @@ return enumerators_added; } -#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE) - class DIEStack { public: void Push(const DWARFDIE &die) { m_dies.push_back(die); } @@ -2557,7 +2555,6 @@ typedef std::vector<DWARFDIE> Stack; Stack m_dies; }; -#endif Function *DWARFASTParserClang::ParseFunctionFromDWARF(CompileUnit &comp_unit, const DWARFDIE &die) {
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits