JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment.
Thanks Tatyana! ================ Comment at: source/API/SBReproducer.cpp:40 + // write into the replay buffer. + char buffer[arch_name_len]; + return SBDebugger::GetDefaultArchitecture(buffer, arch_name_len); ---------------- tatyana-krasnukha wrote: > Array size must be compile-time constant. Fixed in rL355518 ================ Comment at: source/API/SBReproducer.cpp:1120 + LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel, + (lldb::thread_t, lldb::SBError *)); + LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach, ---------------- tatyana-krasnukha wrote: > `lldb::thread_t` is just a `void*` on Windows, so > > `return new UnderlyingT(Deserialize<UnderlyingT>());` > > tries to allocate `void` object. Fixed in rL355519. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
