jingham created this revision. jingham added a reviewer: shafik. Herald added subscribers: lldb-commits, jdoerfert, teemperor, abidh, jfb, aprantl, srhines. Herald added a project: LLDB.
ExpressionSourceCode.cpp is in source/Expressions - which should indicate that it is a generic part of the expression parser. In fact, almost everything it currently does is very Clang specific. This change factors out the clang specific bits into ClangExpressionSourceCode.cpp. It is an NFC change, but it will help to reduce conflicts in supporting other Expression Parsers (e.g. swift). I am leaving ExpressionSourceCode.h in place even though at present it doesn't have much content. In the swift.org repository we have support for emitting debug information for compiled expressions - which requires saving out the expression text, and that is handled by this class. That's a sometimes handy feature. This change will make it easier to merge in that facility, though I'll do that as a separate commit. Repository: rLLDB LLDB https://reviews.llvm.org/D59040 Files: include/lldb/Expression/ExpressionSourceCode.h lldb.xcodeproj/project.pbxproj source/Expression/ExpressionSourceCode.cpp source/Expression/LLVMUserExpression.cpp source/Expression/UserExpression.cpp source/Expression/UtilityFunction.cpp source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
