jingham added a comment.
Also naming quibble...
================
Comment at: lldb/include/lldb/Expression/Expression.h:38
+ /// Discriminator for LLVM-style RTTI (dyn_cast<> et al.)
+ enum ExpressionKind {
+ EK_FunctionCaller,
----------------
I don't think we use this naming for enum's anywhere. Since this is in the
expression class, you don't need the EK. For the equivalent classof enum for
ThreadPlans I use:
typedef enum {
eKindGeneric,
eKindNull,
eKindBase,
eKindCallFunction,
eKindPython,
eKindStepInstruction,
etc...
This is inside a class so you don't need to namespace the enum name like we do
with more general enums.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59314/new/
https://reviews.llvm.org/D59314
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
