aprantl added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:218
+ assert(offset < cu->GetNextCompileUnitOffset() &&
+ debug_info_data.ValidOffset(offset));
----------------
Should this be a lldb_assert() followed by `return make_error` instead?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1170
const dw_offset_t die_offset, Stream &s) {
- if (dwarf2Data == NULL) {
- s.PutCString("NULL");
- return false;
- }
+ assert(dwarf2Data);
----------------
Instead of passing a pointer and asserting, wouldn't it be better to pass a
`SymbolFileDWARF &`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59430/new/
https://reviews.llvm.org/D59430
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
