clayborg added inline comments.
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:393
+ llvm::StringRef LHS, RHS;
+ while (std::tie(Str, Line) = getToken(Line), !Str.empty()) {
+ if (Str.back() == ':') { // regN
----------------
Do we really need to pull the content apart into separate strings for each
register? Seems like a lot of work and 99% of these we will never accessed.
Maybe just store the entire string for all registers and be done?
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:394
+ while (std::tie(Str, Line) = getToken(Line), !Str.empty()) {
+ if (Str.back() == ':') { // regN
+ // Flush the previous expression, if there is one.
----------------
Does the format specify no space between the register name and the colon?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60268/new/
https://reviews.llvm.org/D60268
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
