aprantl added inline comments.
================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:240
public:
Minion(ClangASTImporter &master, clang::ASTContext *target_ctx,
clang::ASTContext *source_ctx)
----------------
Bonus points for coming up with a more descriptive name for this class!
================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:247
+ struct StdModuleScope {
+ StdModuleHandler m_handler;
----------------
Can you add a `///` one-liner for this class?
================
Comment at:
lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/forward_list-basic/TestBasicForwardList.py:17
+ @skipIf(compiler=no_match("clang"))
+ @skipIf(oslist=no_match(["linux"]))
+ @skipIf(debug_info=no_match(["dwarf"]))
----------------
Why wouldn't this work on darwin and/or with a dsym or gmodules or dwo?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59537/new/
https://reviews.llvm.org/D59537
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
