teemperor added a comment.

I believe this revision introduced a warning when compiling with Clang:

   98% [4004/4047] Building CXX object 
tool....dir/PdbFPOProgramToDWARFExpression.cpp.o
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:161:7:
 warning: '(anonymous namespace)::FPOProgramASTVisitor<void>' has virtual 
functions but non-virtual destructor [-Wnon-virtual-dtor]
  class FPOProgramASTVisitor {
        ^
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:190:51:
 note: in instantiation of template class '(anonymous 
namespace)::FPOProgramASTVisitor<void>' requested here
  class FPOProgramASTVisitorMergeDependent : public FPOProgramASTVisitor<> {
                                                    ^
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:190:7:
 warning: '(anonymous namespace)::FPOProgramASTVisitorMergeDependent' has 
virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  class FPOProgramASTVisitorMergeDependent : public FPOProgramASTVisitor<> {
        ^
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:161:7:
 warning: '(anonymous namespace)::FPOProgramASTVisitor<bool>' has virtual 
functions but non-virtual destructor [-Wnon-virtual-dtor]
  class FPOProgramASTVisitor {
        ^
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:232:14:
 note: in instantiation of template class '(anonymous 
namespace)::FPOProgramASTVisitor<bool>' requested here
      : public FPOProgramASTVisitor<bool> {
               ^
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:231:7:
 warning: '(anonymous namespace)::FPOProgramASTVisitorResolveRegisterRefs' has 
virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
  class FPOProgramASTVisitorResolveRegisterRefs
        ^
  
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:310:7:
 warning: '(anonymous namespace)::FPOProgramASTVisitorDWARFCodegen' has virtual 
functions but non-virtual destructor [-Wnon-virtual-dtor]
  class FPOProgramASTVisitorDWARFCodegen : public FPOProgramASTVisitor<> {
        ^
  5 warnings generated.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60410/new/

https://reviews.llvm.org/D60410



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to