Author: jdevlieghere Date: Fri Apr 26 13:03:22 2019 New Revision: 359346 URL: http://llvm.org/viewvc/llvm-project?rev=359346&view=rev Log: [CommandInterpreter] Remove scripting language argument. (NFC)
The script language argument was passed from the debugger to the command interpreter, only to call SetScriptLanguage on the debugger again. It wasn't even used to initialize the script interpreter, because that would query the debugger again. This patch removes the needless back and forth. Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h lldb/trunk/source/Core/Debugger.cpp lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h?rev=359346&r1=359345&r2=359346&view=diff ============================================================================== --- lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h (original) +++ lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h Fri Apr 26 13:03:22 2019 @@ -188,8 +188,7 @@ public: eCommandTypesAllThem = 0xFFFF // all commands }; - CommandInterpreter(Debugger &debugger, lldb::ScriptLanguage script_language, - bool synchronous_execution); + CommandInterpreter(Debugger &debugger, bool synchronous_execution); ~CommandInterpreter() override; @@ -372,8 +371,6 @@ public: void Clear(); - void SetScriptLanguage(lldb::ScriptLanguage lang); - bool HasCommands() const; bool HasAliases() const; Modified: lldb/trunk/source/Core/Debugger.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Debugger.cpp?rev=359346&r1=359345&r2=359346&view=diff ============================================================================== --- lldb/trunk/source/Core/Debugger.cpp (original) +++ lldb/trunk/source/Core/Debugger.cpp Fri Apr 26 13:03:22 2019 @@ -765,8 +765,8 @@ Debugger::Debugger(lldb::LogOutputCallba m_terminal_state(), m_target_list(*this), m_platform_list(), m_listener_sp(Listener::MakeListener("lldb.Debugger")), m_source_manager_up(), m_source_file_cache(), - m_command_interpreter_up(llvm::make_unique<CommandInterpreter>( - *this, eScriptLanguageDefault, false)), + m_command_interpreter_up( + llvm::make_unique<CommandInterpreter>(*this, false)), m_input_reader_stack(), m_instance_name(), m_loaded_plugins(), m_event_handler_thread(), m_io_handler_thread(), m_sync_broadcaster(nullptr, "lldb.debugger.sync"), Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/CommandInterpreter.cpp?rev=359346&r1=359345&r2=359346&view=diff ============================================================================== --- lldb/trunk/source/Interpreter/CommandInterpreter.cpp (original) +++ lldb/trunk/source/Interpreter/CommandInterpreter.cpp Fri Apr 26 13:03:22 2019 @@ -122,7 +122,6 @@ ConstString &CommandInterpreter::GetStat } CommandInterpreter::CommandInterpreter(Debugger &debugger, - ScriptLanguage script_language, bool synchronous_execution) : Broadcaster(debugger.GetBroadcasterManager(), CommandInterpreter::GetStaticBroadcasterClass().AsCString()), @@ -135,7 +134,6 @@ CommandInterpreter::CommandInterpreter(D m_batch_command_mode(false), m_truncation_warning(eNoTruncation), m_command_source_depth(0), m_num_errors(0), m_quit_requested(false), m_stopped_for_crash(false) { - debugger.SetScriptLanguage(script_language); SetEventName(eBroadcastBitThreadShouldExit, "thread-should-exit"); SetEventName(eBroadcastBitResetPrompt, "reset-prompt"); SetEventName(eBroadcastBitQuitCommandReceived, "quit"); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits