This revision was automatically updated to reflect the committed changes.
Closed by commit rL359868: C.128 override, virtual keyword handling (authored
by teemperor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D61440?vs=197922&id=197941#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61440/new/
https://reviews.llvm.org/D61440
Files:
lldb/trunk/include/lldb/Core/Architecture.h
lldb/trunk/include/lldb/Core/StreamBuffer.h
lldb/trunk/include/lldb/Core/ValueObjectVariable.h
lldb/trunk/include/lldb/Target/DynamicLoader.h
lldb/trunk/include/lldb/Target/StackFrameRecognizer.h
lldb/trunk/include/lldb/Target/StructuredDataPlugin.h
lldb/trunk/include/lldb/Utility/Baton.h
lldb/trunk/include/lldb/Utility/DataBufferLLVM.h
lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h
lldb/trunk/source/API/SBBreakpointOptionCommon.h
lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.h
lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp
lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
lldb/trunk/source/Symbol/ClangASTContext.cpp
lldb/trunk/source/Symbol/PostfixExpression.cpp
lldb/trunk/source/Target/StructuredDataPlugin.cpp
lldb/trunk/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
lldb/trunk/unittests/Editline/EditlineTest.cpp
lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
lldb/trunk/unittests/Symbol/TestClangASTContext.cpp
lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
Index: lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
===================================================================
--- lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
+++ lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
@@ -29,11 +29,11 @@
unsigned stop_reply_called = 0;
std::vector<std::string> structured_data_packets;
- void HandleAsyncStdout(llvm::StringRef out) { output += out; }
- void HandleAsyncMisc(llvm::StringRef data) { misc_data += data; }
- void HandleStopReply() { ++stop_reply_called; }
+ void HandleAsyncStdout(llvm::StringRef out) override { output += out; }
+ void HandleAsyncMisc(llvm::StringRef data) override { misc_data += data; }
+ void HandleStopReply() override { ++stop_reply_called; }
- void HandleAsyncStructuredDataPacket(llvm::StringRef data) {
+ void HandleAsyncStructuredDataPacket(llvm::StringRef data) override {
structured_data_packets.push_back(data);
}
};
Index: lldb/trunk/unittests/Symbol/TestClangASTContext.cpp
===================================================================
--- lldb/trunk/unittests/Symbol/TestClangASTContext.cpp
+++ lldb/trunk/unittests/Symbol/TestClangASTContext.cpp
@@ -34,12 +34,12 @@
FileSystem::Terminate();
}
- virtual void SetUp() override {
+ void SetUp() override {
std::string triple = HostInfo::GetTargetTriple();
m_ast.reset(new ClangASTContext(triple.c_str()));
}
- virtual void TearDown() override { m_ast.reset(); }
+ void TearDown() override { m_ast.reset(); }
protected:
std::unique_ptr<ClangASTContext> m_ast;
Index: lldb/trunk/unittests/Editline/EditlineTest.cpp
===================================================================
--- lldb/trunk/unittests/Editline/EditlineTest.cpp
+++ lldb/trunk/unittests/Editline/EditlineTest.cpp
@@ -250,7 +250,7 @@
setenv("TERM", "vt100", 1);
}
- void SetUp() {
+ void SetUp() override {
FileSystem::Initialize();
// Validate the editline adapter.
@@ -263,7 +263,7 @@
std::make_shared<std::thread>([&] { _el_adapter.ConsumeAllOutput(); });
}
- void TearDown() {
+ void TearDown() override {
_el_adapter.CloseInput();
if (_sp_output_thread)
_sp_output_thread->join();
Index: lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
===================================================================
--- lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
+++ lldb/trunk/unittests/Target/ProcessInstanceInfoTest.cpp
@@ -16,13 +16,13 @@
/// for odd ones.
class DummyUserIDResolver : public UserIDResolver {
protected:
- llvm::Optional<std::string> DoGetUserName(id_t uid) {
+ llvm::Optional<std::string> DoGetUserName(id_t uid) override {
if (uid % 2)
return ("user" + llvm::Twine(uid)).str();
return llvm::None;
}
- llvm::Optional<std::string> DoGetGroupName(id_t gid) {
+ llvm::Optional<std::string> DoGetGroupName(id_t gid) override {
if (gid % 2)
return ("group" + llvm::Twine(gid)).str();
return llvm::None;
Index: lldb/trunk/source/API/SBBreakpointOptionCommon.h
===================================================================
--- lldb/trunk/source/API/SBBreakpointOptionCommon.h
+++ lldb/trunk/source/API/SBBreakpointOptionCommon.h
@@ -24,7 +24,7 @@
SBBreakpointCallbackBaton(SBBreakpointHitCallback callback,
void *baton);
- ~SBBreakpointCallbackBaton();
+ ~SBBreakpointCallbackBaton() override;
static bool PrivateBreakpointHitCallback(void *baton,
lldb_private::StoppointCallbackContext *ctx,
Index: lldb/trunk/source/Target/StructuredDataPlugin.cpp
===================================================================
--- lldb/trunk/source/Target/StructuredDataPlugin.cpp
+++ lldb/trunk/source/Target/StructuredDataPlugin.cpp
@@ -23,7 +23,7 @@
"Parent for per-plugin structured data commands",
"plugin structured-data <plugin>") {}
- ~CommandStructuredData() {}
+ ~CommandStructuredData() override {}
};
}
Index: lldb/trunk/source/Symbol/ClangASTContext.cpp
===================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp
@@ -951,7 +951,7 @@
}
void HandleDiagnostic(DiagnosticsEngine::Level DiagLevel,
- const clang::Diagnostic &info) {
+ const clang::Diagnostic &info) override {
if (m_log) {
llvm::SmallVector<char, 32> diag_str(10);
info.FormatDiagnostic(diag_str);
Index: lldb/trunk/source/Symbol/PostfixExpression.cpp
===================================================================
--- lldb/trunk/source/Symbol/PostfixExpression.cpp
+++ lldb/trunk/source/Symbol/PostfixExpression.cpp
@@ -124,23 +124,23 @@
using Visitor<>::Dispatch;
private:
- void Visit(BinaryOpNode &binary, Node *&);
+ void Visit(BinaryOpNode &binary, Node *&) override;
- void Visit(InitialValueNode &val, Node *&);
+ void Visit(InitialValueNode &val, Node *&) override;
- void Visit(IntegerNode &integer, Node *&) {
+ void Visit(IntegerNode &integer, Node *&) override {
m_out_stream.PutHex8(DW_OP_constu);
m_out_stream.PutULEB128(integer.GetValue());
++m_stack_depth;
}
- void Visit(RegisterNode ®, Node *&);
+ void Visit(RegisterNode ®, Node *&) override;
- void Visit(SymbolNode &symbol, Node *&) {
+ void Visit(SymbolNode &symbol, Node *&) override {
llvm_unreachable("Symbols should have been resolved by now!");
}
- void Visit(UnaryOpNode &unary, Node *&);
+ void Visit(UnaryOpNode &unary, Node *&) override;
Stream &m_out_stream;
Index: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
===================================================================
--- lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
+++ lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
@@ -113,7 +113,7 @@
uint32_t GetDependentModules(lldb_private::FileSpecList &files) override;
- virtual lldb_private::Address GetEntryPointAddress() override;
+ lldb_private::Address GetEntryPointAddress() override;
lldb_private::Address GetBaseAddress() override;
Index: lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
===================================================================
--- lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
+++ lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
@@ -65,7 +65,7 @@
void ModulesDidLoad(Process &process, ModuleList &module_list) override;
- ~StructuredDataDarwinLog();
+ ~StructuredDataDarwinLog() override;
private:
// Private constructors
Index: lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
===================================================================
--- lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
+++ lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
@@ -141,7 +141,7 @@
m_collection_sp->Initialize(g_properties);
}
- virtual ~StructuredDataDarwinLogProperties() {}
+ ~StructuredDataDarwinLogProperties() override {}
bool GetEnableOnStartup() const {
const uint32_t idx = ePropertyEnableOnStartup;
Index: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -2659,7 +2659,8 @@
};
class ObjCExceptionThrowFrameRecognizer : public StackFrameRecognizer {
- lldb::RecognizedStackFrameSP RecognizeFrame(lldb::StackFrameSP frame) {
+ lldb::RecognizedStackFrameSP
+ RecognizeFrame(lldb::StackFrameSP frame) override {
return lldb::RecognizedStackFrameSP(
new ObjCExceptionRecognizedStackFrame(frame));
};
Index: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
===================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
+++ lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h
@@ -34,7 +34,7 @@
RenderScriptRuntimeModulePass(const lldb_private::Process *process)
: ModulePass(ID), m_process_ptr(process) {}
- bool runOnModule(llvm::Module &module);
+ bool runOnModule(llvm::Module &module) override;
private:
const lldb_private::Process *m_process_ptr;
Index: lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
===================================================================
--- lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
+++ lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
@@ -33,7 +33,7 @@
PlatformRemoteGDBServer();
- virtual ~PlatformRemoteGDBServer();
+ ~PlatformRemoteGDBServer() override;
// lldb_private::PluginInterface functions
ConstString GetPluginName() override { return GetPluginNameStatic(); }
Index: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
===================================================================
--- lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
+++ lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
@@ -914,7 +914,7 @@
std::unique_ptr<Language::TypeScavenger> CPlusPlusLanguage::GetTypeScavenger() {
class CPlusPlusTypeScavenger : public Language::ImageListTypeScavenger {
public:
- virtual CompilerType AdjustForInclusion(CompilerType &candidate) override {
+ CompilerType AdjustForInclusion(CompilerType &candidate) override {
LanguageType lang_type(candidate.GetMinimumLanguage());
if (!Language::LanguageIsC(lang_type) &&
!Language::LanguageIsCPlusPlus(lang_type))
Index: lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
===================================================================
--- lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
+++ lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
@@ -994,7 +994,7 @@
class ObjCDebugInfoScavenger : public Language::ImageListTypeScavenger {
public:
- virtual CompilerType AdjustForInclusion(CompilerType &candidate) override {
+ CompilerType AdjustForInclusion(CompilerType &candidate) override {
LanguageType lang_type(candidate.GetMinimumLanguage());
if (!Language::LanguageIsObjC(lang_type))
return CompilerType();
Index: lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.h
===================================================================
--- lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.h
+++ lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.h
@@ -51,8 +51,8 @@
class Prefix : public Matcher {
public:
Prefix(ConstString p);
- virtual ~Prefix() = default;
- virtual bool Match(ConstString class_name) override;
+ ~Prefix() override = default;
+ bool Match(ConstString class_name) override;
private:
ConstString m_prefix;
@@ -60,8 +60,8 @@
class Full : public Matcher {
public:
Full(ConstString n);
- virtual ~Full() = default;
- virtual bool Match(ConstString class_name) override;
+ ~Full() override = default;
+ bool Match(ConstString class_name) override;
private:
ConstString m_name;
Index: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
===================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -135,7 +135,7 @@
m_collection_sp->Initialize(g_properties);
}
- virtual ~PluginProperties() {}
+ ~PluginProperties() override {}
uint64_t GetPacketTimeout() {
const uint32_t idx = ePropertyPacketTimeout;
@@ -5158,7 +5158,7 @@
m_option_group.Finalize();
}
- ~CommandObjectProcessGDBRemoteSpeedTest() {}
+ ~CommandObjectProcessGDBRemoteSpeedTest() override {}
Options *GetOptions() override { return &m_option_group; }
@@ -5209,7 +5209,7 @@
: CommandObjectParsed(interpreter, "process plugin packet history",
"Dumps the packet history buffer. ", NULL) {}
- ~CommandObjectProcessGDBRemotePacketHistory() {}
+ ~CommandObjectProcessGDBRemotePacketHistory() override {}
bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount();
@@ -5240,7 +5240,7 @@
"Maximum size that lldb will try to read/write one one chunk.",
NULL) {}
- ~CommandObjectProcessGDBRemotePacketXferSize() {}
+ ~CommandObjectProcessGDBRemotePacketXferSize() override {}
bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount();
@@ -5282,7 +5282,7 @@
"stripped from the result.",
NULL) {}
- ~CommandObjectProcessGDBRemotePacketSend() {}
+ ~CommandObjectProcessGDBRemotePacketSend() override {}
bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount();
@@ -5333,7 +5333,7 @@
"encoded into a valid 'qRcmd' packet, sent and the "
"response will be printed.") {}
- ~CommandObjectProcessGDBRemotePacketMonitor() {}
+ ~CommandObjectProcessGDBRemotePacketMonitor() override {}
bool DoExecute(llvm::StringRef command,
CommandReturnObject &result) override {
@@ -5397,7 +5397,7 @@
interpreter)));
}
- ~CommandObjectProcessGDBRemotePacket() {}
+ ~CommandObjectProcessGDBRemotePacket() override {}
};
class CommandObjectMultiwordProcessGDBRemote : public CommandObjectMultiword {
@@ -5412,7 +5412,7 @@
CommandObjectSP(new CommandObjectProcessGDBRemotePacket(interpreter)));
}
- ~CommandObjectMultiwordProcessGDBRemote() {}
+ ~CommandObjectMultiwordProcessGDBRemote() override {}
};
CommandObject *ProcessGDBRemote::GetPluginCommandObject() {
Index: lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp
===================================================================
--- lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp
+++ lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp
@@ -683,7 +683,7 @@
m_option_group.Finalize();
}
- ~CommandObjectProcessMinidumpDump() {}
+ ~CommandObjectProcessMinidumpDump() override {}
Options *GetOptions() override { return &m_option_group; }
@@ -813,7 +813,7 @@
CommandObjectSP(new CommandObjectProcessMinidumpDump(interpreter)));
}
- ~CommandObjectMultiwordProcessMinidump() {}
+ ~CommandObjectMultiwordProcessMinidump() override {}
};
CommandObject *ProcessMinidump::GetPluginCommandObject() {
Index: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
===================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
@@ -33,7 +33,7 @@
uint32_t compiler_id)
: Diagnostic(message, severity, eDiagnosticOriginClang, compiler_id) {}
- virtual ~ClangDiagnostic() = default;
+ ~ClangDiagnostic() override = default;
bool HasFixIts() const override { return !m_fixit_vec.empty(); }
Index: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -153,7 +153,7 @@
}
void HandleDiagnostic(DiagnosticsEngine::Level DiagLevel,
- const clang::Diagnostic &Info) {
+ const clang::Diagnostic &Info) override {
if (m_manager) {
llvm::SmallVector<char, 32> diag_str;
Info.FormatDiagnostic(diag_str);
@@ -719,7 +719,7 @@
}
/// Deregisters and destroys this code-completion consumer.
- virtual ~CodeComplete() {}
+ ~CodeComplete() override {}
/// \name Code-completion filtering
/// Check if the result should be filtered out.
Index: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
===================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
+++ lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
@@ -36,7 +36,7 @@
public:
DynamicLoaderMacOSXDYLD(lldb_private::Process *process);
- virtual ~DynamicLoaderMacOSXDYLD() override;
+ ~DynamicLoaderMacOSXDYLD() override;
// Static Functions
static void Initialize();
Index: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
===================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
+++ lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
@@ -28,7 +28,7 @@
public:
DynamicLoaderDarwin(lldb_private::Process *process);
- virtual ~DynamicLoaderDarwin() override;
+ ~DynamicLoaderDarwin() override;
/// Called after attaching a process.
///
Index: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
===================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
+++ lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
@@ -32,7 +32,7 @@
public:
DynamicLoaderMacOS(lldb_private::Process *process);
- virtual ~DynamicLoaderMacOS() override;
+ ~DynamicLoaderMacOS() override;
// Static Functions
static void Initialize();
Index: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
===================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
+++ lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
@@ -94,7 +94,7 @@
m_collection_sp->Initialize(g_properties);
}
- virtual ~DynamicLoaderDarwinKernelProperties() {}
+ ~DynamicLoaderDarwinKernelProperties() override {}
bool GetLoadKexts() const {
const uint32_t idx = ePropertyLoadKexts;
Index: lldb/trunk/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
===================================================================
--- lldb/trunk/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
+++ lldb/trunk/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
@@ -302,8 +302,8 @@
class MPXTableShow : public lldb::SBCommandPluginInterface {
public:
- virtual bool DoExecute(lldb::SBDebugger debugger, char **command,
- lldb::SBCommandReturnObject &result) {
+ bool DoExecute(lldb::SBDebugger debugger, char **command,
+ lldb::SBCommandReturnObject &result) override {
if (command) {
int arg_c = 0;
@@ -347,8 +347,8 @@
class MPXTableSet : public lldb::SBCommandPluginInterface {
public:
- virtual bool DoExecute(lldb::SBDebugger debugger, char **command,
- lldb::SBCommandReturnObject &result) {
+ bool DoExecute(lldb::SBDebugger debugger, char **command,
+ lldb::SBCommandReturnObject &result) override {
if (command) {
int arg_c = 0;
Index: lldb/trunk/include/lldb/Core/ValueObjectVariable.h
===================================================================
--- lldb/trunk/include/lldb/Core/ValueObjectVariable.h
+++ lldb/trunk/include/lldb/Core/ValueObjectVariable.h
@@ -74,7 +74,7 @@
bool SetData(DataExtractor &data, Status &error) override;
- virtual lldb::VariableSP GetVariable() override { return m_variable_sp; }
+ lldb::VariableSP GetVariable() override { return m_variable_sp; }
protected:
bool UpdateValue() override;
Index: lldb/trunk/include/lldb/Core/StreamBuffer.h
===================================================================
--- lldb/trunk/include/lldb/Core/StreamBuffer.h
+++ lldb/trunk/include/lldb/Core/StreamBuffer.h
@@ -23,9 +23,9 @@
StreamBuffer(uint32_t flags, uint32_t addr_size, lldb::ByteOrder byte_order)
: Stream(flags, addr_size, byte_order), m_packet() {}
- virtual ~StreamBuffer() {}
+ ~StreamBuffer() override {}
- virtual void Flush() {
+ void Flush() override {
// Nothing to do when flushing a buffer based stream...
}
@@ -42,7 +42,7 @@
protected:
llvm::SmallVector<char, N> m_packet;
- virtual size_t WriteImpl(const void *s, size_t length) {
+ size_t WriteImpl(const void *s, size_t length) override {
if (s && length)
m_packet.append((const char *)s, ((const char *)s) + length);
return length;
Index: lldb/trunk/include/lldb/Core/Architecture.h
===================================================================
--- lldb/trunk/include/lldb/Core/Architecture.h
+++ lldb/trunk/include/lldb/Core/Architecture.h
@@ -16,7 +16,7 @@
class Architecture : public PluginInterface {
public:
Architecture() = default;
- virtual ~Architecture() = default;
+ ~Architecture() override = default;
/// This is currently intended to handle cases where a
/// program stops at an instruction that won't get executed and it
Index: lldb/trunk/include/lldb/Target/DynamicLoader.h
===================================================================
--- lldb/trunk/include/lldb/Target/DynamicLoader.h
+++ lldb/trunk/include/lldb/Target/DynamicLoader.h
@@ -84,7 +84,7 @@
///
/// The destructor is virtual since this class is designed to be inherited
/// from by the plug-in instance.
- virtual ~DynamicLoader() override;
+ ~DynamicLoader() override;
/// Called after attaching a process.
///
Index: lldb/trunk/include/lldb/Target/StructuredDataPlugin.h
===================================================================
--- lldb/trunk/include/lldb/Target/StructuredDataPlugin.h
+++ lldb/trunk/include/lldb/Target/StructuredDataPlugin.h
@@ -41,7 +41,7 @@
: public PluginInterface,
public std::enable_shared_from_this<StructuredDataPlugin> {
public:
- virtual ~StructuredDataPlugin();
+ ~StructuredDataPlugin() override;
lldb::ProcessSP GetProcess() const;
Index: lldb/trunk/include/lldb/Target/StackFrameRecognizer.h
===================================================================
--- lldb/trunk/include/lldb/Target/StackFrameRecognizer.h
+++ lldb/trunk/include/lldb/Target/StackFrameRecognizer.h
@@ -73,7 +73,7 @@
public:
ScriptedStackFrameRecognizer(lldb_private::ScriptInterpreter *interpreter,
const char *pclass);
- ~ScriptedStackFrameRecognizer() {}
+ ~ScriptedStackFrameRecognizer() override {}
std::string GetName() override {
return GetPythonClassName();
Index: lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h
===================================================================
--- lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h
+++ lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h
@@ -34,7 +34,7 @@
StringExtractorGDBRemote(const StringExtractorGDBRemote &rhs)
: StringExtractor(rhs), m_validator(rhs.m_validator) {}
- virtual ~StringExtractorGDBRemote() {}
+ ~StringExtractorGDBRemote() override {}
bool ValidateResponse() const;
Index: lldb/trunk/include/lldb/Utility/Baton.h
===================================================================
--- lldb/trunk/include/lldb/Utility/Baton.h
+++ lldb/trunk/include/lldb/Utility/Baton.h
@@ -44,7 +44,7 @@
class UntypedBaton : public Baton {
public:
UntypedBaton(void *Data) : m_data(Data) {}
- virtual ~UntypedBaton() {
+ ~UntypedBaton() override {
// The default destructor for an untyped baton does NOT attempt to clean up
// anything in m_data.
}
@@ -63,8 +63,7 @@
const T *getItem() const { return Item.get(); }
void *data() override { return Item.get(); }
- virtual void GetDescription(Stream *s,
- lldb::DescriptionLevel level) const override {}
+ void GetDescription(Stream *s, lldb::DescriptionLevel level) const override {}
protected:
std::unique_ptr<T> Item;
Index: lldb/trunk/include/lldb/Utility/DataBufferLLVM.h
===================================================================
--- lldb/trunk/include/lldb/Utility/DataBufferLLVM.h
+++ lldb/trunk/include/lldb/Utility/DataBufferLLVM.h
@@ -25,7 +25,7 @@
class FileSystem;
class DataBufferLLVM : public DataBuffer {
public:
- ~DataBufferLLVM();
+ ~DataBufferLLVM() override;
uint8_t *GetBytes() override;
const uint8_t *GetBytes() const override;
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
