sgraenitz added inline comments.
================ Comment at: lldb/source/Symbol/ClangASTImporter.cpp:68 + return *ret_or_error; + } else { + Log *log = ---------------- aprantl wrote: > The `else` is redundant. Here it's necessary for the scope of `ret_or_error`. That's a bit unfortunate. Maybe invert the condition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits