jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land.
LGTM, though I haven't bothered to inspect the detail of the minidump format. I'll leave it up to you whether you think it's worth getting a separate pair of eyes. ================ Comment at: test/tools/obj2yaml/basic-minidump.yaml:54-57 + - Type: MemoryList + Memory Ranges: + - Start of Memory Range: 0x7C7D7E7F80818283 + Content: '8485868788' ---------------- labath wrote: > jhenderson wrote: > > I'd probably find this neater if the Indentation of values for each entry > > were more consistent, but I'm not too fussed. > > > > Also, in the ThreadList above, the Content is not quoted, but here it is. > > Please standardise it on one or the other. > Done. The different quoting of is actually a relict of how obj2yaml prints > BinaryRef values (they omit quotes if the data happens to be contain hex > (A-F) characters). Do you think it would be worth making this output more > consistent too? Probably, but that sounds like an unrelated changes. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61885/new/ https://reviews.llvm.org/D61885 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
