clayborg added a comment. In D62211#1510903 <https://reviews.llvm.org/D62211#1510903>, @clayborg wrote:
> We really shouldn't have any DWARFDIE references inside > DWARFDebugInfoEntry.h. I noticed there are a lot now which is wrong. I take this back. Many uses are good inside of DWARFDebugInfoEntry as I ok'ed patches when I looked at them. Initially this file was intended to be the level below DWARFDIE, but that has changed, and for good reason: make sure we never use the wrong DWARFUnit with a DWARFDebugInfoEntry. But my initial comment about moving the GetName and AppendTypeName still stand. If we aren't using these for forward references when we don't have all of the DWARFDebugInfoEntry objects parsed already, then they should be moved to DWARFDIE and removed from here. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62211/new/ https://reviews.llvm.org/D62211 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
