kusmour marked an inline comment as done.
kusmour added inline comments.
================
Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1096
+ if (arch_type == llvm::Triple::x86_64
+ && os_type == llvm::Triple::OSType::Win32) {
+ return ABISP(new ABIWindows_x86_64(process_sp));
----------------
compnerd wrote:
> Nit: I think that `arch.GetTriple().isOSWindows()` is nicer than the explicit
> check of `Win32`.
got it
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62213/new/
https://reviews.llvm.org/D62213
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
