[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 202587.
JDevlieghere added a comment.

Adrian's feedback


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62743/new/

https://reviews.llvm.org/D62743

Files:
  lldb/source/Core/Debugger.cpp


Index: lldb/source/Core/Debugger.cpp
===================================================================
--- lldb/source/Core/Debugger.cpp
+++ lldb/source/Core/Debugger.cpp
@@ -120,8 +120,13 @@
   "${module.file.basename}{`${function.name-without-args}"                     
\
   "{${frame.no-debug}${function.pc-offset}}}}"
 
+#define FILE_COLOR "${ansi.fg.yellow}"
+#define STOP_COLOR "${ansi.fg.red}$"
+
 #define FILE_AND_LINE                                                          
\
-  "{ at ${line.file.basename}:${line.number}{:${line.column}}}"
+  "{ at " FILE_COLOR "${line.file.basename}${ansi.normal}"                     
\
+  ":${line.number}{:${line.column}}}"
+
 #define IS_OPTIMIZED "{${function.is-optimized} [opt]}"
 
 #define IS_ARTIFICIAL "{${frame.is-artificial} [artificial]}"
@@ -133,7 +138,7 @@
   "{, queue = '${thread.queue}'}"                                              
\
   "{, activity = '${thread.info.activity.name}'}"                              
\
   "{, ${thread.info.trace_messages} messages}"                                 
\
-  "{, stop reason = ${thread.stop-reason}}"                                    
\
+  "{, stop reason = " STOP_COLOR " ${thread.stop-reason} ${ansi.normal}}"      
\
   "{\\nReturn value: ${thread.return-value}}"                                  
\
   "{\\nCompleted expression: ${thread.completed-expression}}"                  
\
   "\\n"
@@ -143,7 +148,7 @@
   "{, queue = '${thread.queue}'}"                                              
\
   "{, activity = '${thread.info.activity.name}'}"                              
\
   "{, ${thread.info.trace_messages} messages}"                                 
\
-  "{, stop reason = ${thread.stop-reason}}"                                    
\
+  "{, stop reason = " STOP_COLOR " ${thread.stop-reason} ${ansi.normal}}"      
\
   "{\\nReturn value: ${thread.return-value}}"                                  
\
   "{\\nCompleted expression: ${thread.completed-expression}}"                  
\
   "\\n"



Index: lldb/source/Core/Debugger.cpp
===================================================================
--- lldb/source/Core/Debugger.cpp
+++ lldb/source/Core/Debugger.cpp
@@ -120,8 +120,13 @@
   "${module.file.basename}{`${function.name-without-args}"                     \
   "{${frame.no-debug}${function.pc-offset}}}}"
 
+#define FILE_COLOR "${ansi.fg.yellow}"
+#define STOP_COLOR "${ansi.fg.red}$"
+
 #define FILE_AND_LINE                                                          \
-  "{ at ${line.file.basename}:${line.number}{:${line.column}}}"
+  "{ at " FILE_COLOR "${line.file.basename}${ansi.normal}"                     \
+  ":${line.number}{:${line.column}}}"
+
 #define IS_OPTIMIZED "{${function.is-optimized} [opt]}"
 
 #define IS_ARTIFICIAL "{${frame.is-artificial} [artificial]}"
@@ -133,7 +138,7 @@
   "{, queue = '${thread.queue}'}"                                              \
   "{, activity = '${thread.info.activity.name}'}"                              \
   "{, ${thread.info.trace_messages} messages}"                                 \
-  "{, stop reason = ${thread.stop-reason}}"                                    \
+  "{, stop reason = " STOP_COLOR " ${thread.stop-reason} ${ansi.normal}}"      \
   "{\\nReturn value: ${thread.return-value}}"                                  \
   "{\\nCompleted expression: ${thread.completed-expression}}"                  \
   "\\n"
@@ -143,7 +148,7 @@
   "{, queue = '${thread.queue}'}"                                              \
   "{, activity = '${thread.info.activity.name}'}"                              \
   "{, ${thread.info.trace_messages} messages}"                                 \
-  "{, stop reason = ${thread.stop-reason}}"                                    \
+  "{, stop reason = " STOP_COLOR " ${thread.stop-reason} ${ansi.normal}}"      \
   "{\\nReturn value: ${thread.return-value}}"                                  \
   "{\\nCompleted expression: ${thread.completed-expression}}"                  \
   "\\n"

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits