aadsm marked an inline comment as done. aadsm added inline comments.
================ Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:37-39 + lldb::addr_t link_map; + lldb::addr_t base_addr; + lldb::addr_t ld_addr; ---------------- aadsm wrote: > clayborg wrote: > > These seem very linux specific. Why do we need 3 addresses here? Seems like > > we should just need one. Or is this the structure of the > > "xfer:libraries-svr4:read" that is required to be returned? If so, maybe we > > rename "SharedLibraryInfo" to "SVR4ModuleInfo"? > Yes, that is a good point and yes this is the data the SVR4 returns. Given > this structure it makes more sense to move this into the NativeProcessLinux > instead and name it more specifically. Now that I think more about this, SVR4 is really generic to all system v implementations (4.0) so it's not linux specific. Will just change the name to more accurately reflect what is means. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
