clayborg added a comment. In D58678#1530031 <https://reviews.llvm.org/D58678#1530031>, @lanza wrote:
> @clayborg Seems like this still steps into the `call` if the call is the last > instruction in the range. `ThreadPlanStepRange::SetNextBranchBreakpoint` > checks `if (last_index - pc_index > 1)` before setting the breakpoint. So if > `last_index == pc_index` and `pc` points to `call` then the thread plan will > resort to single stepping and thus go through all the same machinery. > Obviously, this isn't a problem as this just leads to using the same > functionality that it used prior to this patch, but you miss out on the > optimization you're aiming for. Thanks for the heads up. Will come up with a fix ASAP Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58678/new/ https://reviews.llvm.org/D58678 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
