aadsm marked an inline comment as done. aadsm added inline comments.
================ Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2181 +template <typename T> +Status NativeProcessLinux::ReadSVR4LibraryInfo(lldb::addr_t link_map_addr, + SVR4LibraryInfo &info, ---------------- labath wrote: > labath wrote: > > This too could return an `llvm::Error`. > > `Expected<std::pair<SVR4LibraryInfo, addr_t>>` is a bit of a mouthful, but > > I'd consider that instead of by-ref returns too.. > What about that llvm::Error? oops sorry, missed this one. I do my best to check if I addressed all the comments but sometimes I miss some :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
