JDevlieghere accepted this revision. JDevlieghere added inline comments.
================ Comment at: source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:66 + const_cast<clang::Type *>(tdecl->getTypeForDecl()))); + return compiler_type; + } ---------------- I think there's a matching constructor, which would allow you to get rid of the temporary and do ``` return CompilerType(ClangASTContext::GetASTContext(&tdecl->getASTContext()),reinterpret_cast<lldb::opaque_compiler_type_t>(const_cast<clang::Type *>(tdecl->getTypeForDecl()))); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62797/new/ https://reviews.llvm.org/D62797 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
