xiaobai added a comment.
In D63240#1560074 <https://reviews.llvm.org/D63240#1560074>, @jingham wrote:
> I was talking specifically about which runtime should be asked the question.
> It seemed to me most straightforward to invert the order in which the
> question was asked, but another way to get the same effect without
> rejiggering the API's at this point is to have
> ValueObject::IsRuntimeSupportValue do:
>
> SymbolContextScope *sym_ctx_scope = GetSymbolContextScope();
> LanguageType languageToAsk = eLanguageTypeUnknown;
> if (sym_ctx_scope) {
> Function *func = sym_ctx_scope->CalculateSymbolContextFunction();
> if (func)
> languageToAsk = func->GetLanguage();
> else //Do something similar for the CU.
>
>
>
>
> Then get the languageRuntime for languageToAsk and ask it. That way you
> don't have to monkey with the runtime language of the ValueObject, but you
> are still asking the right actor.
Right, I see. I'll try to implement something along the lines of what you're
suggesting and report back. Thanks for the suggestion!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63240/new/
https://reviews.llvm.org/D63240
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
