labath added inline comments.
================
Comment at: lldb/include/lldb/Target/Process.h:684
+ /// A status object indicating if the operation was sucessful or not.
+ virtual Status LoadModules() { return Status("Not implemented"); }
----------------
aadsm wrote:
> labath wrote:
> > Since you're already changing the signature, let's make this return an
> > llvm::Error.
> Ah yeah ok. It still weirds me out that an Error object might not be an
> error. In this regard I actually much prefer the Status object as it much
> better conveys the meaning of the return object. Is the plan to move from
> Status to Error in lldb?
Yep. lldb_private::Status used to be called lldb_private::Error, but it was
renamed to avoid confusing with the llvm version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64013/new/
https://reviews.llvm.org/D64013
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
