teemperor created this revision. teemperor added a reviewer: davide. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB.
I saw while debugging that we call this file `ParseInternal`, which is not a very good name for our fake expression file and also adds this unnecessary link between the way we name this function and the other source location names we get from the expression parser. This patch is renaming it to `<lldb-expr>` which is closer to the way Clang names its buffers, it doesn't depend on the function name (which changes when I refactor this code) and it's easier to grep for. Repository: rLLDB LLDB https://reviews.llvm.org/D64545 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Index: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp =================================================================== --- lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp +++ lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp @@ -920,7 +920,7 @@ if (!created_main_file) { std::unique_ptr<MemoryBuffer> memory_buffer = - MemoryBuffer::getMemBufferCopy(expr_text, __FUNCTION__); + MemoryBuffer::getMemBufferCopy(expr_text, "<lldb-expr>"); source_mgr.setMainFileID(source_mgr.createFileID(std::move(memory_buffer))); }
Index: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp =================================================================== --- lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp +++ lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp @@ -920,7 +920,7 @@ if (!created_main_file) { std::unique_ptr<MemoryBuffer> memory_buffer = - MemoryBuffer::getMemBufferCopy(expr_text, __FUNCTION__); + MemoryBuffer::getMemBufferCopy(expr_text, "<lldb-expr>"); source_mgr.setMainFileID(source_mgr.createFileID(std::move(memory_buffer))); }
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits