MaskRay added inline comments.
================ Comment at: lit/Modules/ELF/PT_LOAD-overlap-PT_TLS.yaml:44 +# LOOKUP-LABEL: image lookup -a 0x1010 +# LOOKUP: Address: {{.*}}.PT_LOAD[0]..data + 16) + ---------------- Do you mind explaining more how you'd like to improve file-address-based lookups for PT_TLS? > (lldb) image lookup -a 0x1010 > > Address: a.o[0x00001010] (a.o.PT_LOAD[0]..tdata + 0) This is the current output before the change. Yes PT_TLS can be seen as a separate address space. At runtime a TLS block is allocated (mmap) for each thread and they access TLS through their thread pointer. The address will be very different from the PT_LOAD address. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits