amccarth marked an inline comment as done. amccarth added inline comments.
================ Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; ---------------- hhb wrote: > amccarth wrote: > > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the > > `#define` instead of executing it conditionally. > PATH_MAX is used in SendProcessEvent (line 283) Got it. When I asked Phabricator to show me all the lines, it didn't show me _all_ the lines. That said, it seems unfortunate that it's yet another fixed-length filename buffer instead of getting a ConstString from the FileSpec. But that's outside the scope of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
