JDevlieghere added inline comments.
================
Comment at: lldb/tools/lldb-test/lldb-test.cpp:145
+ "compiler-context",
+ cl::desc("Specify a compiler context as \"[(type,name),...]\"."),
+ cl::value_desc("context"), cl::sub(SymbolsSubcommand));
----------------
aprantl wrote:
> JDevlieghere wrote:
> > > ...as a JSON array...`
> >
> > This makes me wonder though, wouldn't it be better to pass a file here and
> > have it live in inputs? Do you expect it to be different across tests or
> > could we reuse the context across tests?
> I don't really expect a DeclContexts to have more than 3 entries in the
> forseeable future, so that would arguable just make the test harder to read.
But would those entries be the same across tests or not? If they're the same I
think it'd be better to reuse them, even if it's only a few entries.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66453/new/
https://reviews.llvm.org/D66453
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
