JDevlieghere added a comment. In D66447#1637640 <https://reviews.llvm.org/D66447#1637640>, @labath wrote:
> This looks good to me, but why are we using a nul character to test utf8 > support? Shouldn't we insert some funnier characters too? I mean, one of the > advantages of unicode is that it should not be affected by the system code > pages and such, so hopefully this would not cause problems even on some more > exotic setups. (And I am pretty sure I remember already seeing some chinese > chars in some of our data formatter tests) I only glanced at the proposal, but unless I misunderstand the type only fits UTF-8 characters representable in 1 byte, which are basically just ASCII. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66447/new/ https://reviews.llvm.org/D66447 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
