JDevlieghere added a comment.
This looks like a great improvement. Thanks for working on this!
================
Comment at: lldb/include/lldb/Core/PluginManager.h:400
- static TypeSystemEnumerateSupportedLanguages
- GetTypeSystemEnumerateSupportedLanguagesCallbackAtIndex(uint32_t idx);
----------------
🤔
================
Comment at: lldb/include/lldb/Core/PluginManager.h:423
- static REPLEnumerateSupportedLanguages
- GetREPLSystemEnumerateSupportedLanguagesCallbackForPluginName(
- ConstString name);
----------------
🙄
================
Comment at: lldb/source/Core/Debugger.cpp:1628
- Language::GetLanguagesSupportingREPLs(repl_languages);
-
- if (repl_languages.size() == 1) {
- language = *repl_languages.begin();
- } else if (repl_languages.empty()) {
+ if (repl_languages.count() == 1) {
+ language = (LanguageType)repl_languages.find_first();
----------------
Let's wrap this check and the `find_first` call into a method that returns an
`llvm::Optional< LanguageType>`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66546/new/
https://reviews.llvm.org/D66546
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
