shafik added inline comments.
================ Comment at: llvm/include/llvm/Support/MathExtras.h:271 unsigned char out[sizeof(Val)]; - std::memcpy(in, &Val, sizeof(Val)); + memcpy(in, &Val, sizeof(Val)); for (unsigned i = 0; i < sizeof(Val); ++i) ---------------- What are you building on that `memcpy` is not in the `std` namespace? This is non-conforming. C standard library headers provided by `cname` headers have their functions within the `std` namespace and it is unspecified whether these names are available in the global namespace. See [headers p5](http://eel.is/c++draft/headers#5). Also it is not consistent since the `memcpy` below is left as-is. Why does one trigger the warning and not the other? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
