sammccall added a comment. In D65677#1627576 <https://reviews.llvm.org/D65677#1627576>, @JDevlieghere wrote:
> After some brainstorming I've identified a few other approaches that should > better reflect the transience of the current working directory: > > - We can modify the VFS to have a notion of //search paths//. The > `adjustPath` function could iterate over the search paths until it finds an > absolute path that exists. If none exist we'd return the same path we return > today. This would be the most general approach. > - We could create a new virtual file system that we put on top of the > RedirectingFileSystem which does something similar to what I've described > above. This would require us to override every function that calls > `adjustPath`, so it would be pretty heavyweight and rather inflexible. > > I'd like to get your feedback before I start implementing these. What do > you think? Is there another approach that's worth considering? I'm really sorry for missing this comment, I was out sick and missed the email. > I'd like to get your feedback before I start implementing these. Honestly, this still seems way too complicated and this doesn't seem like a feature that needs to be part of VFS. > What do you think? Is there another approach that's worth considering? Per my previous comment, what goes wrong if you try to make the working directory a sibling of VFS (within the reproducer container) rather than a child of it (within shared infrastructure)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
