jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
We don't need to keep this command around. It was originated by Tamas in 2015, https://reviews.llvm.org/D10868 but never got used for anything - Tamas was working on unwind things back then iirc, and may it looks like he thought it would be useful for that. On Darwin systems we do ship with a python command for diagnosing unwind problems ("script import lldb.diagnose"; "diagnose-unwind") which can be used when the current backtrace looks like it may be missing stack frames, or truncate early. The unwinder hasn't seen a lot of active development for years, so we don't have cause to use this very often. I think removing this is fine. The reproducers will be a great way to include everything needed to repro a bug that a user sees. Not everyone can produce a bug report with all of their binaries etc, but the bugreport command suffers from the obvious problem that it can only gather state after something bad has happened. (as Jim notes in the original phab) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
