kwk added a comment. @MaskRay I've addressed your comments.
================ Comment at: lldb/source/Host/common/LZMA.cpp:129 + uint64_t uncompressedSize = 0; + auto err = getUncompressedSize(InputBuffer, uncompressedSize); + if (err) ---------------- labath wrote: > MaskRay wrote: > > if (auto err = ...) > > return err; > I have a feeling this pattern is actually more common in lldb. I tend to use > this one, but I am fine with either. So what now? I had `getCompressedSize` return an error before and changed it upon request to expected. I can live with both but like the expected thing a bit better in terms of: this goes in and this comes out mentality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits