labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM. thanks.
================
Comment at: lldb/include/lldb/API/SBFile.h:31-36
operator bool() const { return IsValid(); }
bool operator!() const { return !IsValid(); }
private:
FileSP m_opaque_sp;
+ SBFile(FileSP file_sp) : m_opaque_sp(file_sp) {}
----------------
All (including private) SB methods should be defined out of line. Otherwise,
their implementation becomes a part of the ABI.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68181/new/
https://reviews.llvm.org/D68181
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
