vsk added a comment.

In D68422#1694147 <https://reviews.llvm.org/D68422#1694147>, @labath wrote:

> Looks good to me. Thanks for doing this. Personally, I'd just remove the 
> `Log` argument from the function argument list, and let the function re-fetch 
> it if needed. I know we sometimes pass around a `Log*` variable, but most of 
> the time we don't...


That's a good idea. I'll post an updated patch -- as it's relatively minor, 
I'll land it Monday afternoon (PST) or so if I don't see any objections.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68422/new/

https://reviews.llvm.org/D68422



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to