MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector<minidump::MemoryInfo> Infos) + : Stream(StreamKind::MemoryInfoList, ---------------- grimar wrote: > Maybe be more explicit here, i.e. > > ``` > std::vector<minidump::MemoryInfo> &&Infos > ``` > ? Or let the constructor take `iterator_range<MinidumpFile::MemoryInfoIterator>` as the argument, and change the call site below. ================ Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:116 + + MemoryInfoListStream() + : Stream(StreamKind::MemoryInfoList, ---------------- Move default constructor above. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
