wallace marked an inline comment as done. wallace added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:63-66 + self.assertRaises( + Exception, + lambda : self.expect("platform process list -xv", substrs=["/system/bin/ls"]) + ) ---------------- labath wrote: > wallace wrote: > > labath wrote: > > > Is this a negative check? We usually use `expect(..., error=True)` for > > > that > > It's a negative test, but error=True checks for the success of the command > > itself, it doesn't check the substrs. > > I took at look at the base classes for testing and it seems I could add > > something like not_contain_substrs, but the code seems very fragile > Ok, how about `matching=False` then? Or maybe you could just put the entirety > of the output to expect into the `patterns` argument, as it should not > contain any values which vary from run to run. damn, i was looking at the wrong implementation of `def expect`... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits