lawrence_danna added a comment. In D68995#1710594 <https://reviews.llvm.org/D68995#1710594>, @labath wrote:
> Thanks for jumping onto this. Apart from the inline comments, I have one high > level question: What are the cases that the old method is wrong for? Was it > just builtin functions, or are there other cases too? Is it possible to fix > it to work for builtings too? (okay, those were three questions) > > What I am wondering is how important it is to maintain two methods for > fetching the argument information. Builtin functions are not likely to be > used as lldb callbacks, so if it's just those, it may be sufficient to just > leave a TODO to use the new method once we are in a position to require > python>=3.3. Looks like the old implementation also doesn't work for class or static methods, or for objects with `__call__` method. I added a bunch of tests for script commands with various callable types in the followon patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
