Author: Raphael Isemann Date: 2019-11-05T09:21:10+01:00 New Revision: db5074dc10222a8202adcd7c1da1acd2828fbecb
URL: https://github.com/llvm/llvm-project/commit/db5074dc10222a8202adcd7c1da1acd2828fbecb DIFF: https://github.com/llvm/llvm-project/commit/db5074dc10222a8202adcd7c1da1acd2828fbecb.diff LOG: [lldb][NFC] Give some parameters in CommandInterpreter more descriptive names Added: Modified: lldb/include/lldb/Interpreter/CommandInterpreter.h lldb/source/Interpreter/CommandInterpreter.cpp Removed: ################################################################################ diff --git a/lldb/include/lldb/Interpreter/CommandInterpreter.h b/lldb/include/lldb/Interpreter/CommandInterpreter.h index 3b98b2a521dd..080d635716f1 100644 --- a/lldb/include/lldb/Interpreter/CommandInterpreter.h +++ b/lldb/include/lldb/Interpreter/CommandInterpreter.h @@ -443,13 +443,13 @@ class CommandInterpreter : public Broadcaster, bool GetPromptOnQuit() const; - void SetPromptOnQuit(bool b); + void SetPromptOnQuit(bool enable); bool GetEchoCommands() const; - void SetEchoCommands(bool b); + void SetEchoCommands(bool enable); bool GetEchoCommentCommands() const; - void SetEchoCommentCommands(bool b); + void SetEchoCommentCommands(bool enable); /// Specify if the command interpreter should allow that the user can /// specify a custom exit code when calling 'quit'. diff --git a/lldb/source/Interpreter/CommandInterpreter.cpp b/lldb/source/Interpreter/CommandInterpreter.cpp index 0c059096c6cd..e02248148413 100644 --- a/lldb/source/Interpreter/CommandInterpreter.cpp +++ b/lldb/source/Interpreter/CommandInterpreter.cpp @@ -137,9 +137,9 @@ bool CommandInterpreter::GetPromptOnQuit() const { nullptr, idx, g_interpreter_properties[idx].default_uint_value != 0); } -void CommandInterpreter::SetPromptOnQuit(bool b) { +void CommandInterpreter::SetPromptOnQuit(bool enable) { const uint32_t idx = ePropertyPromptOnQuit; - m_collection_sp->SetPropertyAtIndexAsBoolean(nullptr, idx, b); + m_collection_sp->SetPropertyAtIndexAsBoolean(nullptr, idx, enable); } bool CommandInterpreter::GetEchoCommands() const { @@ -148,9 +148,9 @@ bool CommandInterpreter::GetEchoCommands() const { nullptr, idx, g_interpreter_properties[idx].default_uint_value != 0); } -void CommandInterpreter::SetEchoCommands(bool b) { +void CommandInterpreter::SetEchoCommands(bool enable) { const uint32_t idx = ePropertyEchoCommands; - m_collection_sp->SetPropertyAtIndexAsBoolean(nullptr, idx, b); + m_collection_sp->SetPropertyAtIndexAsBoolean(nullptr, idx, enable); } bool CommandInterpreter::GetEchoCommentCommands() const { @@ -159,9 +159,9 @@ bool CommandInterpreter::GetEchoCommentCommands() const { nullptr, idx, g_interpreter_properties[idx].default_uint_value != 0); } -void CommandInterpreter::SetEchoCommentCommands(bool b) { +void CommandInterpreter::SetEchoCommentCommands(bool enable) { const uint32_t idx = ePropertyEchoCommentCommands; - m_collection_sp->SetPropertyAtIndexAsBoolean(nullptr, idx, b); + m_collection_sp->SetPropertyAtIndexAsBoolean(nullptr, idx, enable); } void CommandInterpreter::AllowExitCodeOnQuit(bool allow) { _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits