[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

[Alexandre Ganea via Phabricator via lldb-commits]

aganea created this revision.
aganea added a reviewer: jingham.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This fixes a warning on MSVC:

  F:\llvm-project\lldb\source\Commands\CommandObjectThread.cpp(529): warning 
C4305: 'argument': truncation from 'char' to 'bool'

Previously, `'C'` was passed into the wrong parameter, as `is_class` was 
introduced in D68671 <https://reviews.llvm.org/D68671>:

  OptionGroupPythonClassWithDict(const char *class_use,
                                 bool is_class = true,
                                 int class_option = 'C',


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70448

Files:
  lldb/source/Commands/CommandObjectThread.cpp


Index: lldb/source/Commands/CommandObjectThread.cpp
===================================================================
--- lldb/source/Commands/CommandObjectThread.cpp
+++ lldb/source/Commands/CommandObjectThread.cpp
@@ -526,7 +526,7 @@
                                 eCommandProcessMustBeLaunched |
                                 eCommandProcessMustBePaused),
         m_step_type(step_type), m_step_scope(step_scope), m_options(),
-        m_class_options("scripted step", 'C') {
+        m_class_options("scripted step", true, 'C') {
     CommandArgumentEntry arg;
     CommandArgumentData thread_id_arg;
 



Index: lldb/source/Commands/CommandObjectThread.cpp
===================================================================
--- lldb/source/Commands/CommandObjectThread.cpp
+++ lldb/source/Commands/CommandObjectThread.cpp
@@ -526,7 +526,7 @@
                                 eCommandProcessMustBeLaunched |
                                 eCommandProcessMustBePaused),
         m_step_type(step_type), m_step_scope(step_scope), m_options(),
-        m_class_options("scripted step", 'C') {
+        m_class_options("scripted step", true, 'C') {
     CommandArgumentEntry arg;
     CommandArgumentData thread_id_arg;
 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits