labath added a reviewer: jasonmolenda.
labath added a comment.

Presumably, this should change how unwind plans are computed. The unwind 
machinery will treat a `mov %sp, %fp`(whatever is the arm equivalent) as a 
signal that it should switch to an frame-pointer based unwind. This logic 
should not kick in if lldb does not think this register is the frame pointer 
register. You should be able to check this via `image show-unwind`. If that 
shows some difference then it should be possible to concoct a function where 
the unwind goes wrong because of this, but that's not necessary -- it should be 
enough to just check that a reasonable unwind plan is generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70797/new/

https://reviews.llvm.org/D70797



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to