labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Yes, this was long overdue.
================
Comment at: lldb/include/lldb/Core/CursesInterface.h:38-51
+class IOHandlerCursesValueObjectList : public IOHandler {
+public:
+ IOHandlerCursesValueObjectList(Debugger &debugger,
+ ValueObjectList &valobj_list);
+
+ ~IOHandlerCursesValueObjectList() override;
+
----------------
Is this class actually used anywhere? Can we delete it and rename this file to
a plain `IOHandlerCursesGUI.h` ?
================
Comment at: lldb/source/Commands/CommandObjectGUI.cpp:14
#include "lldb/lldb-private.h"
+#include "lldb/Core/CursesInterface.h"
----------------
What's up with these random blank lines? It seems everyone is adding them based
on some different key... llvm does not use blank lines at all and just relies
on clang-format to produce a "reasonable" include block.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70946/new/
https://reviews.llvm.org/D70946
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
