clayborg added inline comments.
================ Comment at: lldb/scripts/Python/python-typemaps.swig:124 } else { - llvm::StringRef ref(static_cast<const char*>($1), result); + llvm::StringRef ref = static_cast<char*>($1); PythonString string(ref); ---------------- This assignment looks a bit goofy IMHO. Just remove result from original code?: ``` llvm::StringRef ref(static_cast<char*>($1)); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits