davide added a comment.

In D72413#1813630 <https://reviews.llvm.org/D72413#1813630>, @teemperor wrote:

> The C++ expression parser will probably behave incredibly incorrectly without 
> a persistent state but before this patch it just crashed, so I think this is 
> good to go.


Should we consider a refactor to `ClangExpressionDeclMap` that makes this more 
obvious? [and maybe allows us to not sprinkling these checks everywhere] -- as 
a followup?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72413/new/

https://reviews.llvm.org/D72413



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to