labath added a comment.

If I understand this correctly, this will cause lldb to continue to read the 
parsed line table contribution after encountering some errors in the prologue, 
whereas previously we would stop straight away. That sounds reasonable if now 
or in the future we will be able to get some useful information (at least some 
subset of file names, or line numbers without file names, etc.) out of these 
kinds of line tables. If that is not the case, and these errors are recoverable 
only in the sense that they allow you to jump to the next contribution, then it 
might be better to treat these errors as unrecoverable for lldb purposes 
(jumping to the next contribution is not interesting for us since we always use 
DW_AT_stmt_list to locate the line table).

However, I don't think that resolving that needs to hold this patch up, as this 
behavior can be easily adjusted from within lldb.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72158/new/

https://reviews.llvm.org/D72158



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to