[Lldb-commits] [PATCH] D74018: [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks for doing this!



================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:507
 
     size_mode_value = (size_mode->GetValueAsUnsigned(0));
     short_mode = ((size_mode_value & 0x80) == 0);
----------------
Would it make sense to split the computation of `size_mode_value` and 
`short_mode` into a helper?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74018/new/

https://reviews.llvm.org/D74018



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits