labath added a comment.
Yeah, we should fill in the other attributes too. As that will probably
noticeably increase the amount of code, it would be good to put this stuff into
a separate function (or two..). For a test, you could create some kind of a
lldb-server test (packages/Python/lldbsuite/test/tools/lldb-server/). I am
imagining something that will check that this parses as valid xml, and then
does some kind of basic validation on the contents.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2832
+ response.Printf("</target>");
+ return MemoryBuffer::getMemBufferCopy(response.GetString(), __FUNCTION__);
+ }
----------------
"target.xml" would be a better buffer name than `__FUNCTION__`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74217/new/
https://reviews.llvm.org/D74217
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
