aykevl added a comment. In D74255#1871958 <https://reviews.llvm.org/D74255#1871958>, @labath wrote:
> However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement `__builtin_debugbreak()` -- I am assuming that's > what 0x98 0x95 is), then I don't see a problem with this function returning > it. As Dylan already mentioned, the opcode is indeed for the BREAK instruction. Here it is: https://github.com/llvm/llvm-project/blob/release/9.x/llvm/test/MC/AVR/inst-break.s https://www.microchip.com/webdoc/avrassembler/avrassembler.wb_BREAK.html The documentation even states: > The BREAK instruction is used by the On-Chip Debug system, and is normally > not used in the application software. I would argue that even though the direct need for this patch may be to work around a limitation elsewhere, it is a useful change on its own. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/ https://reviews.llvm.org/D74255 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
