JDevlieghere planned changes to this revision. JDevlieghere marked an inline comment as done. JDevlieghere added a comment.
In D73016#1900403 <https://reviews.llvm.org/D73016#1900403>, @labath wrote: > This looks fine, but I think you'll first need to handle the lit changes to > allow skipping tests. Otherwise all of the pdb and breakpad tests will break > once you do this. I guess the reason that this hasn't happened yet is because > you have a typo in your cache file. Right, I fixed the cache and then applied an old diff again. Shouldn't have tried to squeeze this in on a Sunday night. With the right cache values `lldb-server` is failing to link, so I'll have to take a look at that too. ================ Comment at: lldb/source/API/SBCommandReturnObject.cpp:98-101 + std::ofstream reproducer_log_file; + reproducer_log_file.open(lldb_private::repro::Reproducer::Instance().IsCapturing() ? "/tmp/capture.log" : "/tmp/replay.log", std::fstream::app); + reproducer_log_file << output.AsCString(/*value_if_empty*/ "") << "\n"; + reproducer_log_file.close(); ---------------- labath wrote: > ? Ugh, this should've been stashed, I was digging into some reproducer failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73016/new/ https://reviews.llvm.org/D73016 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits