labath added a reviewer: jingham.
labath added a subscriber: jingham.
labath added a comment.

Clearing all settings is a reasonable operation, so I don't have any problem 
with it per se. I'm just wondering, given that this is not something that one 
would want to do very often (and it can have catastrophic results), whether 
this operation should not be more explicit. "settings clear --all" for instance 
? Adding @jingham for the interface aspects.

It would also be nice to add a test case for the new command.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75537/new/

https://reviews.llvm.org/D75537



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to