wallace created this revision.
wallace added reviewers: clayborg, aadsm, kusmour.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
kusmour accepted this revision.
This revision is now accepted and ready to land.
On Linux, when executing lldb-vscode on a remote machine, lldb-vscode doesn't
die after the debug session ends. It keeps trying to read JSON input to no
avail.
This diff indicates lldb-vscode to stop reading after a termination event has
been processed.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D76314
Files:
lldb/tools/lldb-vscode/lldb-vscode.cpp
Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -2821,7 +2821,7 @@
}
auto request_handlers = GetRequestHandlers();
uint32_t packet_idx = 0;
- while (true) {
+ while (!g_vsc.sent_terminated_event) {
std::string json = g_vsc.ReadJSON();
if (json.empty())
break;
Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -2821,7 +2821,7 @@
}
auto request_handlers = GetRequestHandlers();
uint32_t packet_idx = 0;
- while (true) {
+ while (!g_vsc.sent_terminated_event) {
std::string json = g_vsc.ReadJSON();
if (json.empty())
break;
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
